Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documents and bencher_compat dep refer outdated criterion v0.4 #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhysd
Copy link

@rhysd rhysd commented Jan 19, 2024

This PR fixes the following two issues:

  • Documents including the quick start guide still use old criterion v0.4. When users refer them, they would accidentally use the old version instead of the latest v0.5.1
  • criterion_bencher_compat depends on criterion crate v0.4. But the current version in the workspace is v0.5.1. So cargo check reports the following error
    error: failed to select a version for the requirement `criterion = "^0.4.0"`
    candidate versions found which didn't match: 0.5.1
    location searched: /path/to/criterion.rs
    required by package `criterion_bencher_compat v0.4.0 (/path/to/criterion.rs/bencher_compat)`
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant